-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #54 to add DevServices for Artemis JMS #55
Conversation
Hi @middagj , Can you review these changes? and I'd like to include them in a new release if it makes sense. Thanks! |
Sure, it can take a few days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the addition, some comments.
core/deployment/src/main/java/io/quarkus/artemis/core/deployment/ArtemisBuildTimeConfig.java
Show resolved
Hide resolved
...ment/src/main/java/io/quarkus/artemis/core/deployment/ArtemisDevServicesBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
...ployment/src/main/java/io/quarkus/artemis/jms/deployment/DevServicesArtemisJmsProcessor.java
Outdated
Show resolved
Hide resolved
...ployment/src/main/java/io/quarkus/artemis/jms/deployment/DevServicesArtemisJmsProcessor.java
Outdated
Show resolved
Hide resolved
...deployment/src/main/java/io/quarkus/artemis/core/deployment/DevServicesArtemisProcessor.java
Outdated
Show resolved
Hide resolved
We should be able to also use testcontainers on core integration test. If you have time, could you add that, otherwise I will add it myself. Also we don't need the broker.xml files. |
yeah, I will add one in core integration test. And |
correct I think I misunderstood the test then, I thought it was only using the testcontainers. |
Thanks for the PR |
Could you give it a test, and confirm it works as expected in your project. I will then release. |
Thanks @middagj and yeah I confirm it works in my camel-quarkus -example project. Please go heading for the release. |
@middagj I just realized that |
I didn't realize you added it, will remove it. |
I raise #60 |
No description provided.